Skip to content

Upgrade sidekiq-cron gem

Heinrich Lee Yu requested to merge 343695-upgrade-sidekiq-cron into master

What does this MR do and why?

Upgrades sidekiq-cron and adds an explicit require for sidekiq/job_logger. Previously, this was loaded by sidekiq-cron's launcher which is now refactored to only load the Sidekiq classes when needed.

This is the 2nd attempt since !73093 (merged) was reverted due to gitlab-com/gl-infra/production#5819 (closed)

This problem is fixed because Sidekiq Cluster now loads Bundler: 5e2f02c3. So it should now be able to require the class from Sidekiq.

Links

How to set up and validate locally

  1. Run Sidekiq and verify that cron jobs are being enqueued

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343695 (closed)

Edited by Heinrich Lee Yu

Merge request reports

Loading