Refactor specs prevent_cross_database_modification_spec
What does this MR do and why?
Some time ago we made all specs default to preventing cross database
modification. Thus the prevent_cross_database_modification
tag was
unecessary. This meant slightly re-organising the tests and removing 1
redundant test and re-writing one test slightly since it wasn't covered
elsewhere.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #341783 (closed)