Skip to content

Default jira_use_first_ref_by_oid feature flag to true

Stan Hu requested to merge sh-jira-use-first-ref-by-oid-ff-default into master

What does this MR do and why?

In gitlab-com/gl-infra/production#5662 (comment 697826180), we saw a lot of requests for FindAllTags that never completed. A project with JIRA enabled would attempt to call:

noteable.ref_names(project.repository).first

The FindAllTags triggered by ProcessCommitWorker comes from the JIRA integration. This happens when the commit message references a JIRA issue.

In gitaly!3947 (merged), we added a new RPC FindRefsByOID. The purpose of this RPC is to, as the name suggests, find refs by passing in an object id and some other optional parameters.

!72739 (merged) has been on production for several weeks now, and the RPC landed in GitLab 14.5 so let's flip this feature on to true by default for 14.6.

Relates to:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports