Skip to content

Use Pipeline Editor to add new CI file from Suggest Pipeline banner

Eugie Limpin requested to merge suggest-pipeline-banner-to-pipeline-editor into master

What does this MR do and why?

It includes the following changes:

  1. It updates the copy of the Suggest Pipeline banner (as per gitlab-org/growth/team-tasks#399 (closed))
  2. It updates the behavior of the CTA button in the Suggest Pipeline banner to take the user to the Pipeline Editor (with starter template filled in) instead of the file editor (to add a .gitlab-ci.yml file).

Screenshots or screen recordings

Before

  • User is taken to single file editor to create a .gitlab-ci.yml file

before

After

  • User is taken to the Pipeline Editor skipping the empty state screen
Expand to see GIF of Pipeline Editor showing empty state screen pe_start_screen

after

How to set up and validate locally

Setup

  1. Create a MR without pipelines
    • Create a project with Auto DevOps disabled in the project settings CI/CD section (Auto DevOps will add pipelines to a MR which we don't want)
    • Create a MR in the project with Auto DevOps disabled (edit the README in Web IDE and commit with create MR option checked)

Validate

  1. Go to the MR without pipeline
  2. Validate that the new version (updated copy) of the suggest pipeline banner is shown
    Screenshot of the new version of suggest pipeline banner Screen_Shot_2021-11-08_at_1.05.12_PM
  3. Click on the "Try out GitLab Pipelines"
  4. Validate that you are taken to the Pipeline Editor (empty state screen is skipped)
    GIF showing user taken to Pipeline Editor from suggest pipeline banner after

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Frédéric Caplette

Merge request reports

Loading