Skip to content

Truncate long table values in on-demand scans page

What does this MR do and why?

This improves the on-demand scans page UX by...

  • ...adjusting columns' width to make more room for longer values.
  • ...truncating scan names and target URLs when they are too long to fit in their cells.
  • ...exposing truncated values' full text in a tooltip (made possible with gitlab-ui!2467 (merged)).
  • ...top-positioning Started at tooltips to make them consistent with other tooltips in the list.

Screenshots or screen recordings

Before

Overflow Start date tooltip
Screen_Shot_2021-11-03_at_12.29.14_PM Screen_Shot_2021-11-03_at_12.29.22_PM

After

Responsiveness
responsive
Name Target URL Start date
Screen_Shot_2021-11-03_at_12.26.23_PM Screen_Shot_2021-11-03_at_12.26.31_PM Screen_Shot_2021-11-03_at_12.26.38_PM

How to set up and validate locally

  1. Enable the on-demands scans page.
    Feature.enable(:dast_view_scans)
  2. This MR is temporarily running a development build of @gitlab/ui, so make sure your dependencies are up-to-date by running:
    yarn
  3. Visit any project's on-demand scans page such as http://127.0.0.1:3000/groups/flightjs/-/on_demand_scans.
    • If you have never run on-demand scans before, follow the empty state's instructions to run at least one, then comme back to this page.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341370 (closed)

Edited by Jannik Lehmann

Merge request reports

Loading