Skip to content

Improve Blame Page rendering performance

Stanislav Lashmanov requested to merge cyberap/gitlab:improve-blame-page-rendering into master

What does this MR do and why?

This MR supercedes !73739 (closed). It's also a follow-up on !73173 (merged).

It was discovered that Total Blocking Time metric got a significant degradation after recent changes to how content-visibility is applied on the Blame Page. This MR applies content-visiblity: auto to line numbers on the Blame Page in order to fix that.

Screenshots or screen recordings

Performance measurements on Low-end device

Click to expand
Master branch This branch
before1 after1
before2 after2
before3 after3

Performance measurements on High-end device

Click to expand
Master branch This branch
beforePC1 afterPC1
beforePC2 afterPC2
beforePC3 afterPC3

How to set up and validate locally

  1. Open GDK on this page: http://localhost:3000/gnuwget/Wget2/-/blame/master/tests/libtest.c
  2. Measure performance using Performance tab in DevTools
  3. Repeat that for master branch

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stanislav Lashmanov

Merge request reports