Disable Code Suggestion for ipynb diffs
What does this MR do and why?
We added a cleaner diffs for jupyter notebooks (#341825 (closed)), but when a code suggestion is applied to the notebook, it breaks the file (#345075 (closed)). As mitigation, we are disabling code suggestions for notebooks.
Note: This MR doesn't provide a changelog because it is part of a feature that is being deployed in this version
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Enable the feature flag:
- Open the rails consoles (
rails c) Feature.enable(:jupyter_clean_diffs)- Create a mirror of this https://gitlab.com/gitlab-org/incubation-engineering/mlops/ipynb-test-projects/diff-sample into your GDK instance
- Make sure the feature is enabled and create an MR from any branch into main (eg
svg-latex) - Create a suggestion
- Verify that the suggestions can't be applied
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Resolves #345075 (closed)
Edited by Pedro Moreira da Silva