Skip to content

Update QA CI check for feature flag changes

Will Meek requested to merge qa-ci-ff-update into master

What does this MR do and why?

Describe in detail what your merge request does and why.

As per 9653eb61 (comment 726485120)

It appears that for feature flag removals that run package-and-qa, CI is detecting changes to feature flags, but the set is empty as the feature flag has been removed, and GitLab-QA then fails on the empty set.

This MR simply checks if the set is empty.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

As this is CI based, I propose 2 draft MRs - not for merging - to test CI which are based on this branch.

!73981 (closed)

From test:

[32;1m$ echo $GITLAB_QA_OPTIONS[0;m

QA pipeline succeeds.

  • A draft MR which introduces an FF

!73984 (closed)

From test:

[0;m[32;1m$ echo $GITLAB_QA_OPTIONS[0;m
--set-feature-flags package_list_apollo_eleven=disable

QA pipeline succeeds.

Check logs of instance test for output like

[0;m[32;1m$ echo $GITLAB_QA_OPTIONS[0;m
--set-feature-flags test-feature-flag
...
Running with feature flag: --set-feature-flags test-feature-flag --
Docker shell command: `docker run -t --rm --net=test --env QA_IMAGE="$QA_IMAGE" --env QA_DEBUG="$QA_DEBUG" --env (env variables cut) Test::Instance::All http://gitlab-ee-c771f882.test --set-feature-flags test-feature-flag -- --format QA::Support::JsonFormatter --out "tmp/rspec-1752515522.json" --format RspecJunitFormatter --out "tmp/rspec-1752515522.xml" --format html --out "tmp/rspec-$(echo ee:instance-parallel 1/5 | sed 's/[ /]/_/g').htm" --color --format documentation`

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Will Meek

Merge request reports