Skip to content

Remove projects with disabled issues in new issue dropdown

Coung Ngo requested to merge cngo-update-issues-refactor into master

What does this MR do and why?

This MR removes projects with disabled issues in the new issue dropdown on the group issues list page.

In the group issues page refactor behind feature flag vue_issues_list, the new issue dropdown showed all projects. The correct behaviour is that it should show only projects with issues enabled. This logic is tested in spec/features/groups/issues_spec.rb:121.

#322755 (closed)

Screenshots or screen recordings

Before (contains h5bp test again which has issues disabled`) After (does not contain h5bp test again which has issues disabled`)
Screenshot_2021-11-09_at_4.03.09_pm Screenshot_2021-11-09_at_4.06.10_pm
Screenshot_2021-11-09_at_4.06.17_pm

How to set up and validate locally

  1. In rails console enable the feature flag
    Feature.enable(:vue_issues_list)
  2. Ensure a project has issues disabled in its settings, e.g. http://127.0.0.1:3000/h5bp/h5bp-test-again/edit#js-general-project-settings
  3. Visit the group issues page, e.g. http://127.0.0.1:3000/groups/flightjs/-/issues
  4. Test the new issue dropdown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Coung Ngo

Merge request reports

Loading