Skip to content

Fix help links for merge request approvals

Pedro Moreira da Silva requested to merge pms-fix-approvals-help-links into master

What does this MR do and why?

Fixes the help links for the merge request approvals documentation in https://docs.gitlab.com/ee/user/project/merge_requests/approvals/index.html

The broken links recently surfaced in https://twitter.com/yavladikku/status/1456637261223710729?s=21

Screenshots or screen recordings

image

How to set up and validate locally

For the approvals link

  1. Use a free instance or set up the project to have optional approvals
  2. Visit a merge request and look for the approvals widget
  3. Click on the (?) icon next to Approval is optional

For the eligible approvals link

  1. Use licensed instance
  2. Visit a merge request and expand the approvals widget
  3. Click on the (?) icon next to Eligible users

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading