Skip to content

Add table and pagination to deploy keys Vue conversion

What does this MR do and why?

Part of #344927 (closed)

Adds table data and pagination to admin deploy keys view. This builds on top of !73580 (merged).

What this MR doesn't do? (will be implemented in future MRs)

  1. Open confirmation modal when remove button is clicked
  2. Add total count of deploy keys to page title. e.g. Deploy keys (54)

Screenshots or screen recordings

Desktop

Before After
gdk.peterhegman.com_3000_admin_deploy_keys__1_ gdk.peterhegman.com_3000_admin_deploy_keys

Mobile

Before After
Screen_Shot_2021-11-16_at_12.20.29_PM Screen_Shot_2021-11-16_at_12.17.47_PM

How to set up and validate locally

  1. Fire up the Rails console
    • bin/rails console
  2. Create some deploy keys
50.times do
    project = Project.order("RANDOM()").first
    deploy_key = FactoryBot.create(:deploy_key, public: true)
    FactoryBot.create(:deploy_keys_project, :write_access, deploy_key: deploy_key, project: project)
end
  1. Enable the admin_deploy_keys_vue feature flag
    • Feature.enable(:admin_deploy_keys_vue)
  2. Sign in as an Admin and navigate to /admin/deploy_keys

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports

Loading