Skip to content

Enable API v3 `branches/:sha` partial response

Luke Duncalfe requested to merge 344617-remove-api_v3_commits_skip_diff_files-feature-flag into master

What does this MR do and why?

This MR enables the api_v3_commits_skip_diff_files feature flag #344617 (closed). This flag helps mitigate the effect of GRPC::DeadlineExceeded timeout exceptions on an API endpoint #331326 (closed).

The flag is being kept around in a form that can be disabled because the cases where the timeout was occurring were for a handful of commit SHAs. We'd like to retain the ability to disable this flag if there are still customers that find the solution is regressive for them.

The flag has been enabled in production since November 9th #344617 (comment 727287828).

There are tests of the flag in spec/requests/api/v3/github_spec.rb.

There is no documentation change because the endpoint the flag affects (An api/v3 endpoint: repos/:namespace/:project/commits/:sha) is used by Jira integrations rather than the public, and so is not documented.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344617 (closed)

Edited by Luke Duncalfe

Merge request reports