Render Corpus table with real data
What does this MR do and why?
Allows ability to save corpus as per #342580 (closed)
Notes for Reviewers
This MR covers happy path. Validation errors, and deletion, and ux tweaks will follow.
Frontend Implementation Plan (Remaining Issues)
Issue | Weight | Milestone | Description |
---|---|---|---|
#342433 (closed) | frontend-weight3 | %14.5 | Upload Corpus (Merged) |
#342580 (closed) | frontend-weight2 | %14.5 | Commit Corpus (Merged) |
#345088 (closed) | frontend-weight3 | %14.5 | Swap out mock table data for real query (THIS MR) |
#345985 | frontend-weight3 | %14.6 | Test Resolvers |
#345090 (closed) | frontend-weight3 | %14.6 | Corpus table pagination |
#342581 (closed) | frontend-weight3 | %14.6 | Corpus Modal Delete |
#342583 (closed) | frontend-weight2 | %14.6 | Modal validation errors |
#345089 (closed) | frontend-weight3 | %14.6 | Inline delete |
#346055 (closed) | ~"frontend-weight:1" | %14.6. | Address UX Feedback adjustments |
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Validation errors will be handled in #342583
- From the gitlab repo open a rails console and enable the :corpus_management feature flag
bundle exec rails c
then
[4] pry(main)> Feature.enable(:corpus_management)
Navigate to:
http://172.16.123.1:3000/<group>/<project>/-/security/configuration/corpus_management
Click on New Corpus
, upload any zip
file of a large size. 500 MB > (or in chrome debugger, throttle network traffic so we can see upload progress)
Click "Add", should see the corpus added to the table
(NOTE - you will need to add at least 10 corpuses to be able to go between pages, otherwise the buttons are greyed out)
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #345088 (closed)