Skip to content

Fixes cross-db modification for Ci::JobArtifacts::DestroyBatchService

Thong Kuah requested to merge split_main_geo_db_operations_for_ci_job_artifacts_destroy into master

What does this MR do and why?

Fixes cross-db modification for Ci::JobArtifacts::DestroyBatchService

Split out main, and geo DB out of CI transaction. We should not run main, and geo DB operations in the context of a CI transaction. We split it out into a pre-, and post- set of DB operations.

At this point it should be OK for the security_finding to be deleted, regardless of whether the Ci::JobArtifact are successfully delete or not. If the Ci::JobArtifact deletion fails, another worker will try again.

Related issue: #345444 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports