Skip to content

Set retry metadata instead of running with around

Lin Jen-Shin requested to merge 345798-set-retry-metadata into master

What does this MR do and why?

Set retry metadata instead of running with around.

This should make sure it doesn't mess with rspec-retry

How to set up and validate locally

  • Run this under difference scenarios: env FLAKY_RSPEC_GENERATE_REPORT=true RETRIES=3 bin/rspec spec/controllers/registrations_controller_spec.rb:12
  • When it's passing, RspecFlaky::Listener#example_passed will only run once
  • When we try to break the test, it did not run more than once

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345798 (closed)

Edited by Rémy Coutable

Merge request reports