Improve cancel button experience in Pipeline editor
requested to merge 300444-pipeline-editor-improve-cancel-button-experience-in-commit-form into master
What does this MR do and why?
Before when in the pipeline editor, clicking on cancel would reset the content of your file to be what it was before you started working without warning. This commit changes that to show a confirmation modal.
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2021-11-17_at_3.22.29_PM | Screen_Recording_2021-11-17_at_12.50.59_PM_1_ |
How to set up and validate locally
- Go to CI => Editor
- Notice the button on the bottom right is now called "Reset"
- Click on it: nothing happens
- Modify the CI config
- Click on the reset button
- Notice a confirmation modal appears
- Clicking on "Reset content" will restore your Ci config to what it was before
- Clicking on "cancel" will keep your changes
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #300444 (closed)
Edited by Frédéric Caplette