Skip to content

Fix broken spec for private events being included in the calendar

Dustin Eckhardt requested to merge eggerd/gitlab:eggerd-master-patch-87554 into master

First MR 👋🚀

What does this MR do and why?

This fixes the spec for private events being shown to all users on the contribution calendar, if the contributor opted-in.

Currently the include_private_contributions option gets applied to the user (aka "visitor") instead of the contributor and therefore has no effect - so disabling/removing the option doesn't change the test outcome, which it should.

The fix applies the option to the contributor and validates that all two events are shown to all users.

How to set up and validate locally

  1. Run the spec with 
    rspec spec/lib/gitlab/contributions_calendar_spec.rb:68

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports