Skip to content

Include sidekiq_middleware in coverage report

Thong Kuah requested to merge sidekiq_middleware_include_coverage into master

What does this MR do and why?

Include sidekiq_middleware in coverage report. It was found in RCA for gitlab-com/gl-infra/production#5931 (closed), that this directory was excluded from coverage reports.

By chance a file in this directory was changed, and that changed method had no coverage, due to stubbing. So we remove the add_filter that prevents lib/gitlab/sidekiq_middleware from being included in the coverage report

Screenshots or screen recordings

The coverage visualization will now show for lib/gitlab/sidekiq_middleware, for example:

Screen_Shot_2021-11-18_at_9.03.39_PM

(note: this is slightly inaccurate, see #345987 (closed))

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports