Skip to content

Use GitLab fork of LicenseFinder and update version to 6.14.2.1

Balasankar 'Balu' C requested to merge bump-license-finder into master

What does this MR do and why?

LicenseFinder v6.0.0 has a bug where it fails to fetch license texts properly, which has been fixed in later versions. See example below for proof

image

This causes license text collection in omnibus-gitlab to fail - omnibus-gitlab!5734 (comment 738080847)

This was fixed in later versions of LicenseFinder. However, those versions have a strong constraint on thor version 1.0.1, which will result the thor in our bundle to be downgraded. But, thor started supporting Ruby 3 from version 1.1.0 only, so this downgrade is not preferred.

Hence, we ended up forking LicenseFinder and relaxed the thor dependency because our usecases of LicenseFinder are not affected by the changes made to thor.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Balasankar 'Balu' C

Merge request reports