Skip to content

Improving pipeline editor E2E test

Tiffany Rea requested to merge 345999-improve-pipeline-editor-test into master

What does this MR do and why?

Describe in detail what your merge request does and why.

While investigating #345999 (closed), I realized this test needs some improvement as well as enhancement.

  • There is a sidebar on the right that belongs to pipeline editor and will be expanded by default if the page thinks that it was the first time the user opens this feature. Add logic to close it if it is expanded to avoid issue with not able to click on element later on if they are covered.
  • Removed checks for elements on page and add require: true instead since these are must have elements of the page anyways, and that will cut some execution time as well.
  • Only wait for requests at appropriate place instead of wait for specific elements.
  • Update tests
    • Use ProjectPush when pushing new branch
    • Removed unnecessary variables
    • Add wait logic for new branch in case it takes some time to be created
    • Add expectation for when branch is switched, the CI file content should also be updated accordingly.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

See test case for more details https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1891

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345999 (closed)

Merge request reports