Add some filtered search token improvements and fixes
What does this MR do and why?
This MR adds some filtered search token improvements and fixes.
- Allow any token component that implements
BaseToken
to getrecentSuggestionsStorageKey
from the config, so we don't have to do:recent-suggestions-storage-key="config.recentSuggestionsStorageKey"
in every implementing token - Fix bug where
activeTokenValue
parameter ofhandleTokenValueSelected
inBaseToken
is undefined - Show
No matches found
when there are no results from a search - On group/project issues list, add recent suggestions for various tokens
- On group/project issues list, match filtered bar labels search on title only. GraphQL doesn't allow title-only filtering so this is done in the frontend for now (backend issue: #346353)
Screenshots or screen recordings
no matches found | recently used |
---|---|
BEFORE: activeTokenValue undefined bug (selection does not get added to recently used section) |
AFTER: activeTokenValue undefined bug fixed (selection gets added to recently used section) |
---|---|
Screen_Recording_2021-12-01_at_11.25.05_am | Screen_Recording_2021-12-01_at_11.25.33_am |
How to set up and validate locally
- In rails console enable the feature flag
Feature.enable(:vue_issues_list)
- Visit any group or project issues list page such as
http://127.0.0.1:3000/groups/flightjs/-/issues
- Test the MR
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Coung Ngo