Skip to content

Update 'Merge Request' in SAST UI page

Amy Qualls requested to merge aqualls-sast-mr-language into master

What does this MR do?

As part of the epic &6436 for improving the merge request widget UI text, we uncovered some edge cases where 'merge request' was used incorrectly in other places in the UI.

When configuring SAST settings (your project → Security & Compliance → Configuration) several buttons on the page used the same Configure via Merge Request text. In this instance, merge request shouldn't be capitalized at all, and if we can get away from using via at the same time, let's do it.

This merge request updates that text in the UI, tests, translation file, and documentation. Currently to Configure it with a merge request but this opinion is loosely held - I care more about the capitalization than the removal of the via.

Screenshots

(The wording has changed slightly since these screenshots are taken, but the screenshots accurately show what in the UI is changing - button wording.)

Before before
After after

Related issues

Related to #346053 (closed) where I'm capturing all the messages we're polishing in %14.6.

Author's checklist

If you are only adding documentation, do not add any of the following labels:

  • ~"type::feature"
  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Review checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  • Ensure a release milestone is set.
Edited by Amy Qualls

Merge request reports