Skip to content

Use additional headers for matching service desk email

Jarka Košanová requested to merge 346600-sd-to-headers into master

What does this MR do and why?

There are 2 ways how to configure Service desk - either using the general incoming email address or configuring a custom service desk address.

In the general email receiver we check not only email to but also additional headers. Therefore also eg. replies are correctly identified. We don't do that in the Service desk receiver.

This MR fixes that (and also includes small refactoring)

How to set up and validate locally

  1. Configure incoming emails
  2. [Configure custom email address for service desk](1. Configure incoming emails)
  3. Update gitlab-mail_room gem to version 0.0.13 in https://gitlab.com/gitlab-org/gitlab/-/blob/master/Gemfile#L442
  4. Run mailroom bundle exec mail_room -c './config/mail_room.yml'
  5. Go to project settings and find support desk address (eg. http://127.0.0.1:3000/flightjs/Flight/edit)
  6. Send an email to that address, cc another email that you have access to
  7. Check the project issues, a new issue should be created (eg. http://127.0.0.1:3000/flightjs/Flight/-/issues)
  8. Go to the second email account, a new email should arrive
  9. Respond to that email, don't forget to include support desk email among the recipients (Reply all)
  10. Go to the previously created issue, a new comment should be created

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346600 (closed)

Merge request reports