Skip to content

Move Security ConfigurationPresenter to FOSS

Tetiana Chupryna requested to merge 342135-move-presenters into master

What does this MR do and why?

As SAST and SecretDetection features are moved to GitLab Free, we need to migrate some parts of the codebase to FOSS. This MR move ConfigurationPresenter and related code. That enables us to create proper security configuration for GitLab Free users.

This is a second attempt to merge these changes. The First attempt !72631 (merged) was reverted due to the found regression #345724 (closed).

This MR fixes regression and adds more feature tests to ensure that everything works correctly.

Screenshots or screen recordings

pic 1

Screenshot_2021-12-14_at_18.14.58

pic 2

Screenshot_2021-12-14_at_18.15.06

How to set up and validate locally

  1. On a GitLab instance with an Ultimate license,
  2. Create a project, go to the Security -> Configuration page.
  3. Observe that everything works correctly.

At the moment, we don't use ConfigurationPresenter for GitLab Free.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #342135 (closed)

Edited by Tetiana Chupryna

Merge request reports

Loading