VerifyPagesDomain: suffix with . indicate absolute fqdn
What does this MR do and why?
Append .
to domain_name
(if not present) in check
function of VerifyPagesDomainService before performing DNS queries with Resolver. This ensures that the FQDN is treated as an absolute query, bypassing search
list and ndots
specification.
IETF RFC 1034, section 3.1 clarifies:
Since a complete domain name ends with the root label, this leads to
a printed form which ends in a dot. We use this property to distinguish
between:
- a character string which represents a complete domain name
(often called "absolute"). For example, "poneria.ISI.EDU."
Relates to gitlab-org/charts/gitlab#3008
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Jason Plum