Skip to content

Fixed NoMethodError on import from GitHub Enterprise on RFC1918 IP

Colin Barr requested to merge colinbarr/gitlab:337273-github-import into master

What does this MR do and why?

With allow_local_requests_from_web_hooks_and_services set to false in GitLab settings, an attempt to import from GitHub Enterprise on a local/RFC1918 IP address would have resulted in a NoMethodError. This change fixes that bug to correctly handle, log, and return the error.

Resolves #337273 (closed)

How to set up and validate locally

Reproduction steps are documented in #337273 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337273 (closed)

Merge request reports