Skip to content

GraphQL: Add NEVER_CONTACTED runner status

Pedro Pombeiro requested to merge pedropombeiro/344671/add-never-connected-runner-state into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR deprecates the existing NOT_CONNECTED runner status enum value and adds a more expressive NEVER_CONTACTED replacement value. It also adds a matching Runner model scope.

The new value is returned if (legacyMode: null) is passed to the status resolver. If no argument is passed or (legacyMode: "14.5") is passed, then the legacy NOT_CONNECTED value is returned.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

query getRunners {
  runners {
    nodes {
      id
      description
      shortSha
      contactedAt
      status: status(legacyMode: null)
      legacyStatus: status
    }
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Deprecation issue: #347303 (closed)

Part of #344671 (closed)

Edited by Pedro Pombeiro

Merge request reports