Set 'Low' Custom Error Budget Thresholds - APIs
What does this MR do and why?
From the list except the GraphQL endpoints which I don't believe we can set urgency per endpoint currently, I've set the urgency to 'low` for following API endpoints.
I tried to group them based on the endpoint url, but they do get mixed up due to how we structure our code.
I find it difficult to set urgencies for dynamically generated endpoints so I opted to use url based approach which I think may not be as precise due to the different HTTP method that can be used against the same url. I think that's good enough, but we may need to revisit them later.
| # | Request type | json.meta.caller_id.keyword: Descending | 99.5th percentile of json.duration_s | 99.8th percentile of json.duration_s | Count | Source file | |
|---|---|---|---|---|---|---|---|
| 103 | GET | /api/:version/groups/:id/merge_requests | 2.895000572 | 5.396566548 | 846792 | lib/api/merge_requests.rb | |
| 55 | HEAD | /api/:version/merge_requests | 1.39154364 | 1.535855386 | 873 | lib/api/merge_requests.rb | |
| 81 | GET | /api/:version/merge_requests | 1.26163855 | 3.047449681 | 5925196 | lib/api/merge_requests.rb | |
| 60 | HEAD | /api/:version/projects/:id/merge_requests | 1.402394648 | 1.841987808 | 829 | lib/api/merge_requests.rb | |
| 64 | GET | /api/:version/projects/:id/merge_requests | 1.34114926 | 2.277975098 | 65095400 | lib/api/merge_requests.rb | |
| 112 | POST | /api/:version/projects/:id/merge_requests | 4.696142287 | 7.269640869 | 43959 | lib/api/merge_requests.rb | |
| 89 | GET | /api/:version/projects/:id/merge_requests/:eventable_id/resource_label_events | 1.456213149 | 3.649840534 | 19525 | lib/api/resource_label_events.rb | |
| 87 | GET | /api/:version/projects/:id/merge_requests/:eventable_id/resource_milestone_events | 1.396865978 | 3.468432112 | 14538 | lib/api/resource_milestone_events.rb | |
| 74 | GET | /api/:version/projects/:id/merge_requests/:eventable_iid/resource_state_events | 1.265186141 | 2.585915896 | 19989 | lib/api/resource_state_events.rb | |
| 85 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid | 1.846209459 | 3.374909222 | 4980336 | lib/api/merge_requests.rb | |
| 90 | DELETE | /api/:version/projects/:id/merge_requests/:merge_request_iid | 1.746891754 | 3.822233852 | 2114 | lib/api/merge_requests.rb | |
| 101 | PUT | /api/:version/projects/:id/merge_requests/:merge_request_iid | 2.270210371 | 5.356158965 | 2576617 | lib/api/merge_requests.rb | |
| 66 | POST | /api/:version/projects/:id/merge_requests/:merge_request_iid/award_emoji | 1.421250433 | 2.294631882 | 18182 | lib/api/award_emoji.rb | |
| 69 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/award_emoji | 1.17603411 | 2.410232529 | 4771959 | lib/api/award_emoji.rb | |
| 50 | DELETE | /api/:version/projects/:id/merge_requests/:merge_request_iid/award_emoji/:award_id | 0.7582017195 | 1.480252289 | 914 | lib/api/award_emoji.rb | |
| 80 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/changes | 1.981253145 | 3.010965872 | 1147428 | lib/api/merge_requests.rb | |
| 86 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/closes_issues | 1.467813013 | 3.376673494 | 1154704 | lib/api/merge_requests.rb | |
| 47 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/commits | 0.770628789 | 1.358091066 | 2052268 | lib/api/merge_requests.rb | |
| 120 | PUT | /api/:version/projects/:id/merge_requests/:merge_request_iid/merge | 5.881275168 | 11.3854891 | 56513 | lib/api/merge_requests.rb | |
| 56 | POST | /api/:version/projects/:id/merge_requests/:merge_request_iid/notes/:note_id/award_emoji | 1.345323129 | 1.617985045 | 857 | lib/api/award_emoji.rb | |
| 44 | DELETE | /api/:version/projects/:id/merge_requests/:merge_request_iid/notes/:note_id/award_emoji/:award_id | 0.5696018216 | 1.271896463 | 537 | lib/api/award_emoji.rb | |
| 49 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/participants | 1.072217965 | 1.437860294 | 265557 | lib/api/merge_requests.rb | |
| 91 | PUT | /api/:version/projects/:id/merge_requests/:merge_request_iid/rebase | 3.186936742 | 3.896678991 | 3165 | lib/api/merge_requests.rb | |
| 48 | GET | /api/:version/projects/:id/merge_requests/:merge_request_iid/versions/:version_id | 0.858838394 | 1.360017716 | 800211 | lib/api/merge_request_diffs.rb | |
| 51 | GET | /api/:version/projects/:id/merge_requests/:noteable_id/discussions | 1.051854104 | 1.500439642 | 2284690 | lib/api/discussions.rb | |
| 124 | POST | /api/:version/projects/:id/merge_requests/:noteable_id/discussions | 19.59850328 | 20.41683075 | 14210 | lib/api/discussions.rb | |
| 63 | PUT | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id | 1.359141478 | 2.235948064 | 5535 | lib/api/discussions.rb | |
| 111 | GET | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id | 3.626505194 | 7.220490438 | 2096 | lib/api/discussions.rb | |
| 43 | GET | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id/notes | 1.006393457 | 1.25588653 | 933 | lib/api/discussions.rb | |
| 113 | POST | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id/notes | 4.393497527 | 8.098590627 | 805 | lib/api/discussions.rb | |
| 76 | PUT | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id/notes/:note_id | 1.57587214 | 2.772752088 | 6911 | lib/api/discussions.rb | |
| 83 | DELETE | /api/:version/projects/:id/merge_requests/:noteable_id/discussions/:discussion_id/notes/:note_id | 2.197197938 | 3.090288782 | 2970 | lib/api/discussions.rb | |
| 45 | HEAD | /api/:version/projects/:id/merge_requests/:noteable_id/notes | 1.270694538 | 1.27579999 | 129 | lib/api/notes.rb | |
| 58 | GET | /api/:version/projects/:id/merge_requests/:noteable_id/notes | 1.079409795 | 1.738601768 | 9172088 | lib/api/notes.rb | |
| 96 | POST | /api/:version/projects/:id/merge_requests/:noteable_id/notes | 2.674035713 | 4.628104141 | 93681 | lib/api/notes.rb | |
| 68 | DELETE | /api/:version/projects/:id/merge_requests/:noteable_id/notes/:note_id | 1.547643328 | 2.320641017 | 16600 | lib/api/notes.rb | |
| 102 | PUT | /api/:version/projects/:id/merge_requests/:noteable_id/notes/:note_id | 2.997371464 | 5.394053312 | 99181 | lib/api/notes.rb | |
| 127 | PUT | /api/:version/suggestions/:id/apply | 42.45368942 | 54.76732198 | 3324 | lib/api/suggestions.rb | |
| 128 | PUT | /api/:version/suggestions/batch_apply | 52.30336823 | 55.52191267 | 628 | lib/api/suggestions.rb |
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #346803 (closed)
Edited by Sincheol (David) Kim