Skip to content

Generates discussion_id when importing notes from GitHub

Heinrich Lee Yu requested to merge 346495-generate-discussion-id-when-importing-github-notes into master

What does this MR do and why?

The GitHub importer skips callbacks so the discussion_id isn't generated. This is fine because we also generate it at runtime when the note is rendered.

But it is still better to generate it and persist it so that a note does not have a different discussion id every time it is rendered.

The discussion_id is also going to be used for paginating discussions.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346495 (closed)

Edited by Heinrich Lee Yu

Merge request reports