Skip to content

Add support for multiple databases for migration observers

Diogo Frazão requested to merge 40-lib-gitlab-database-migrations-observers-migration_observer-rb-should-work-with-many-database into master

What does this MR do and why?

This MR adds support for multiple databases for the migration observers. Before, we were hardcoding the connection (ActiveRecord::Base.connection), and now we pass the connection as an argument.

Changes:

  • MigrationObserver starts to accept a connection as an argument
  • Migrations::Runner passes a connection when observes a migration
  • Fix specs

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to gitlab-org/database-team/gitlab-com-database-testing#40 (closed)

Edited by Diogo Frazão

Merge request reports