Add register_group_runners rule to GroupPolicy
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR introduces a new :register_group_runners
rule in GroupPolicy
. This allows us to replace a usage where frontend is testing for the :admin_pipeline
permission in order to determine whether to show the setup instructions for a group runner.
A similar MR was recently merged: !76682 (merged)
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
In rails console enable runner registration control
Feature.enable(:runner_registration_control)
-
Visit http://gdk.test:3000/admin/application_settings/ci_cd#js-runner-settings on your GDK
- In the
Runner registration
section, disable theMembers of the group can register runners
checkbox
- In the
-
Visit the Settings -> CI/CD -> Runners section for a project that is the child of a group, e.g. http://gdk.test:3000/groups/h5bp/-/settings/ci_cd. The Group runners section should look like this:
-
Retry step 2, this time enabling the checkbox.
-
In the screen described in step 3, you should now see the following:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Closes #348337 (closed)