Skip to content

Fix flaky Redis-Sessions spec

Aleksei Lipniagov requested to merge 348135-fix-flaky-redis-session-specs into master

What does this MR do and why?

Resolves the issue described in #348135 (closed) which was reported by Heinrich.
The Redis-Sessions multistore spec is flaky, depending on the order of the class vars cleanup.
This aims to fix it.

How to set up and validate locally

  1. bash: rm config/redis.sessions.yml. Or mv. Otherwise, the spec will pass, as it would pick up the proper config.
  2. bin/spring rspec spec/lib/gitlab/redis/shared_state_spec.rb spec/lib/gitlab/redis/sessions_spec.rb - will fail on the master
  3. The same sequence will be green on this branch.
  4. Restore the file. Or reconfigure GDK which would do just that.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #348135 (closed)

Merge request reports