Skip to content

Fix an issue with sorting Vulnerability Report

Dheeraj Joshi requested to merge djadmin-fix-vulnerability-report-sorting-behavior into master

Related issue - #348416 (closed)

What does this MR do and why?

This fixes an issue with the Vulnerability Report where clicking on the non-sortable field leads to dashboard unavailability.

This was found to be due to a missing validation for empty field names, and thus emitting sort-changed with incorrect value.

Screenshots or screen recordings

before after
vuln_report_sort_before vuln_report_sort_after

How to set up and validate locally

  1. Visit vulnerability dashboard
  2. Click non-sortable column header, viz. Identifier or Activity
  3. The Dashboard disappears with an error message on master as well as on gitlab.com
  4. After this change, the dashboard should load fine upon clicking the aforementioned column heads.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dheeraj Joshi

Merge request reports