Global Search Refactor - Fix Input Border
What does this MR do and why?
This addresses a regression found in here: !74244 (comment 731485313)
Work towards #297396 (closed)
This change is behind a feature flag (:new_header_search)
Feature Flag Rollout Issue: #339348 (closed)
This change fixes the issue of the inset box shadow (visually looks to be a border) that is new to the Header Search. This change focuses on making the box shadow match better with all the themes using similar logic to the input backgrounds.
Screenshots or screen recordings
Zoom in of the change
| Before | After | |
|---|---|---|
| Indigo |  |
 |
| Light Indigo |  |
 |
| Blue |  |
 |
| Light Blue |  |
 |
| Green |  |
 |
| Light Green |  |
 |
| Red |  |
 |
| Light Red |  |
 |
| Dark |  |
 |
| Light |  |
 |
| Dark Mode |  |
 |
How to set up and validate locally
- Fetch and checkout this branch
- Activate the Feature Flag
- Cycle through the themes and see the new inset box shadow
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Zack Cuddy