Make additions to group/project issues list refactor
What does this MR do and why?
This MR makes additions to the group/project issues list Vue refactor (#322755 (closed)), behind the feature flag vue_issues_list
defaulted off.
- Disable anonymous searching when
disable_anonymous_search
ops feature flag is enabled (this currently happens on the existing Haml issues list) - Show issues list errors below filtered search bar (as decided by UX in #323743 (comment 752276275))
- Sort filtered search tokens alphabetically (as decided by UX in https://gitlab.slack.com/archives/CGR5T3WMP/p1639451925134400?thread_ts=1639444233.130100&cid=CGR5T3WMP)
- Fix sort parameter values (will fix
spec/features/projects/labels/issues_sorted_by_priority_spec.rb
whenvue_issues_list
is enabled in the feature specs)
Screenshots or screen recordings
anonymous searching | issues list error message | alphabetical tokens |
---|---|---|
How to set up and validate locally
- In rails console enable the feature flags
Feature.enable(:vue_issues_list) Feature.enable(:disable_anonymous_search)
- Visit any group or project issues list page such as
http://127.0.0.1:3000/groups/h5bp/-/issues
- Test the MR
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #322755 (closed)
Edited by Coung Ngo