Skip to content

Resolve "Make badges in app/views/shared/members/_badge.html.haml Pajamas-compliant"

David Pisek requested to merge 344411-make-badges-in-app-views-shared-members-_badge-html-haml-pajamas-compliant into master

What does this MR do and why?

Makes the badge within app/views/shared/members/_badge.html.haml Pajamas compliant.

Screenshots or screen recordings

before after (no visible changes)
Screen_Shot_2021-12-17_at_9.35.17_pm Screen_Shot_2021-12-17_at_9.41.05_pm

How to set up and validate locally

  1. Check out master
  2. Apply the following patch display show all available badges for ever user (as in screenshot above): show_all_badges_master.patch
  3. Navigate to /admin/projects/twitter/Typeahead.Js and check the badges on the members list
  4. Check out this branch (344411-make-badges-in-app-views-shared-members-_badge-html-haml-pajamas-compliant)
  5. Apply the following patch: show_all_badges_pajamas_compliant.patch
  6. Make sure there is no visible difference to before

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344411 (closed)

Edited by David Pisek

Merge request reports