Skip to content

Fix N+1 problem for system notes metadata association

Vasilii Iakliushin requested to merge fix_n_1_for_note_metadata into master

What does this MR do and why?

Follow-up for #347407 (closed)

In the previous MR I added a permission verification when user requests the list of participants. But it increased the number of db queries.

I found that notes association does not preload system notes metadata object and that generates additional queries.

Screenshots or screen recordings

Before After
Screenshot_2021-12-16_at_16.43.28 Screenshot_2021-12-16_at_16.49.01

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports