Skip to content

Refactor dependency list to use provide/inject for static values

Jannik Lehmann requested to merge jnnkl-provide-inject-refactor into master

What does this MR do and why?

This MR solves: #348581 (closed) It is a follow up Issue from !76446 (merged)

The dependency list app and the license_compliance app, had a couple of constants passed into as props which were static rather than reactive. So as a good practice this values should be passed in using provide/inject rather than props.

This MR fixes that.

Screenshots or screen recordings

no visual changes.

How to set up and validate locally

  1. Go to a project which has the license_compliance and the dependency scanning jobs activated
  2. See if http://gitlab.localdev:3000/GROUP/PROJECT/-/licenses renders correctly
  3. See if http://gitlab.localdev:3000/GROUP/PROJECT/-/dependencies renders correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading