Skip to content

Resolve "Make badges in app/views/projects/merge_requests/invalid.html.haml Pajamas-compliant"

Thomas Randolph requested to merge tor/maintenance/badge-migration/app--views--projects--merge_requests--invalid.html.haml into master

What does this MR do and why?

Closes #344380 (closed)

Updates the badges used in app/views/projects/merge_requests/invalid.html.haml to use the new badge helper utility.

Screenshots or screen recordings

Note that there's no difference here, as the styles match exactly.

Before After
image image

How to set up and validate locally

I can't figure out how to get this to actually show in normal operation.

When I delete a branch, GitLab closes my MR instead of showing these errors. If I delete a branch in the middle of creating an MR, the MR is created just fine but shows "no changes".

So I edited app/controllers/projects/merge_requests_controller.rb def show to simply be render('invalid') and it showed my branch deletion (for example).

  1. Create a branch with a change
  2. Start the process of creating an MR for it
  3. Before clicking the button to finalize your MR creation, delete the branch
  4. Click the button to create the MR
  5. Edit the file above and refresh the page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Randolph

Merge request reports