Skip to content

Group API Plans Performance

Drew Blessing requested to merge dblessing_group_projects_api_perf into master

What does this MR do and why?

Part of #330140 (closed), but does not completely resolve it.

There are many components coming together to cause long request times for the related issue. One piece we identified was an N+1 associated with loading group plans. This only seems to have a modest improvement in times but it eliminates an N+1 and gets us closer to improving this endpoint. See !77538 (comment 801295242) for stats.

Feature flag

This introduces a new development feature flag :group_project_api_preload_plans which is off by default. Once deployed we can enable this feature flag and measure results. As long as timings improve and there are no negative effects we can remove the feature flag subsequently.

This should not be a long-lived FF - it's a safety net and a tool to allow us to measure results.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Drew Blessing

Merge request reports