Skip to content

Hide subs expiration banner before eligible

Vladlena Shumilo requested to merge 341211-hide-banner-before-elegible-saas into master

What does this MR do and why?

Since customers-gitlab-com#3268 (closed) customers are only able to renew 15 days before the subscription expiration date.

Current logic was accounting for a wider period (30 days) to display the subscription expiration banner resulting in a state where Customers might initiate the "Renew" action and navigate to CustomersDot to realize the option is not yet available.

This generated confusion, we want to update the expiration banner logic to display aligned to the renewal period.

📸 Screenshots or screen recordings

These screenshots were taken on 2022-01-21

Note: There is a miss-alignment on how the remaining days count is displayed in both systems, this has been raise please disregard for the review of this MR given it was not introduced with the current changes

This is a subscription that will expire in 16 days, note:

  • CustomersDot has the "Renewal" option disabled
  • The banner is not displayed in Gitlab

Screen_Shot_2022-01-21_at_3.45.14_PMScreen_Shot_2022-01-21_at_3.34.32_PM

This is a subscription that will expire in 15 days, note:

  • CustomersDot has the "Renewal" option enabled
  • The banner is displayed in Gitlab

Screen_Shot_2022-01-21_at_3.45.07_PM Screen_Shot_2022-01-21_at_3.37.42_PM

How to set up and validate locally

(Images that might help are listed in the Screenshot section)

  • Create some subscriptions in Zuora associated to the account you use for CustomersDot
    • Create a subscription that will expire in 15 days
    • Create a subscription that will expire in 16 days
    • Make sure these are NOT set to Autorenew
  • Via your gdk, create 2 groups to associate these subscriptions to.
    • Make sure these are set to display in .com mode
  • Via CustomersDot associate the subscriptions to the groups
  • Navigate to your groups and double check that:
    • Group with the subscriptions expiring in 15 days
      • Shows expiration banner
      • Triggering the Renew takes you to the Renew in CustomersDot (is enabled)
    • Group with the subscriptions expiring in 16 days
      • Shows NO expiration banner
      • You cannot renew via CustomersDot

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #341211

Edited by Vladlena Shumilo

Merge request reports