Skip to content

Reintroduced vulnerability_management_survey for survey Banner

What does this MR do and why?

Issue: #349767 (closed)

This MR fixes a bug that was introduced with !77583 (merged)

While refactoring the vulnerability Management Survey to use the sharedSurvey Component the check for the vulnerability_management_survey was mistakenly removed. This MR reintroduces the check.

Screenshots or screen recordings

vulnerability_management_survey = true

before after
Screenshot_2022-01-07_at_10.13.36 Screenshot_2022-01-07_at_10.13.36

vulnerability_management_survey = false

before after
Screenshot_2022-01-07_at_10.13.36 Screenshot_2022-01-07_at_10.14.01

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. rails c
  2. Feature.enable(:vulnerability_management_survey)
  3. go to http://gitlab.localdev:3000/GROUP/PROJECT/-/security/vulnerability_report/
  4. you should see the banner
  5. rails c
  6. Feature.disable(:vulnerability_management_survey)
  7. go to http://gitlab.localdev:3000/GROUP/PROJECT/-/security/vulnerability_report/
  8. you should not see the banner

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports

Loading