Skip to content

Detect SystemExit in tests and convert it to an error

Lin Jen-Shin requested to merge stub-rake-exit-in-tests into master

What does this MR do and why?

Detect SystemExit in tests and convert it to an error

Because if we let it fall through, it'll stop the tests early. Make sure it's handled.

We do 2 things here:

  • Make sure we catch all potential SystemExit so we never cut the tests early
  • This also reverts !77955 (merged) in case we do need exit right there.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

See #350060 (closed)

Edited by Lin Jen-Shin

Merge request reports

Loading