Skip to content

Remove event hub from integrations app

Tom Quirk requested to merge 348382-integration-form-remove-event-hub into master

What does this MR do and why?

Related to #348382 (closed).

This MR removes the event hub from the Integrations Vue app 🎉.

The final event to remove was VALIDATE_INTEGRATION_FORM_EVENT. To remove it, we've added isValidated props to the form field components, and set this prop from the parent component, integration_form.vue. When we need form validation, integration_form.vue sets these props to true, and the form field components handle as necessary, internally.

There are no user-facing changes in this MR

Screenshots or screen recordings

Screenshots demonstrate that form validation works as expected (unchanged):

event_hub

How to set up and validate locally

You'll need to set up an integration, and fill out the form fields incorrectly to trigger form validation.

To set up an integration:

  1. Navigate to a GitLab project.
  2. Select Settings > Integrations from the left sidebar.
  3. Select Jira.
  4. Complete the form details, but leave Web URL blank.
  5. Click "save changes".
  6. Observe. A form validation message should appear on the Web URL field.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #348382 (closed)

Edited by Tom Quirk

Merge request reports