Skip to content

Remove dangling todos for multi-database offenses

Patrick Bair requested to merge pb-remove-dangling-database-offenses into master

What does this MR do and why?

In the epic &7369 (closed), we are removing unsafe usages of ActiveRecord::Base.connection as part of the effort to support multiple databases in the app.

This MR cleans up a number of stale offenses in the rubocop todo file that have already been fixed. I also fixed a few simple offenses as I was cleaning up.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Patrick Bair

Merge request reports