Skip to content

Clean up Asana integration specs

Andy Schoenen requested to merge andysoiron/cleanup-asana-specs into master

What does this MR do and why?

This is a cleanup of the Asana integrations tests. It:

  • Changes let to let_it_be where database records are created.
  • Replaces the create_data_for_commits method with let(:data).
  • Wraps test cases in context blocks, so the test setup can be moved outside the examples.

Why is this change necessary

I started to look into #349359 (closed) (confidential) and through about it can be covered by a test. Adding a new test case will be easier when the contexts are used.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports