Skip to content

Improve Sidekiq jobs that use DB load balancing

Heinrich Lee Yu requested to merge improve-lb-sidekiq-jobs into master

What does this MR do and why?

Removing this FF changes the way we handle Sidekiq jobs that read from DB replicas. The job will no longer be scheduled 1 second in the future because this adds considerable overhead to Sidekiq and Redis.

The Sidekiq job would just sleep for at most 1 second if the replica is not up to date.

This has already been enabled on GitLab.com for more than a month.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports