Clean up IssuableEscalationStatuses::PrepareUpdateService
What does this MR do and why?
Related issue: #348958 (closed)
This MR does a little cleanup as a follow-up from !76819 (merged). This refactor has no user-facing changes, as the feature is still behind a feature flag. But there is a small functional change (bugfix).
Three main things are in this MR:
- Swapping the service to inherit from
BaseProjectService
- Swapping service to defend against errors instead of raising/catching
- Reduces "cognitive complexity" of
filter_policy
method/logic - [Only functional change/bugfix]: Don't unset the policy if a status change occurs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Sarah Yasonik