Skip to content

Blob refactor: Fix/update blob show specs

Jacques Erasmus requested to merge blob-show-spec into master

What does this MR do and why?

Up until now, we've disabled the :refactor_blob_viewer feature flag in the ruby specs so that we could refactor the blob viewer frontend without the majority of our specs failing.

As we're getting ready to rollout the blob refactor we need to ensure that all specs pass with the :refactor_blob_viewer enabled. This MR enables the feature flag on the majority of the specs and fixes the breaking specs accordingly.

Note, changes in this MR is behind the :refactor_blob_viewer feature flag.

Screenshots or screen recordings

Screenshot_2022-01-25_at_13.01.17

How to set up and validate locally

  1. Enable the Blob Viewer Refactor feature flag
Feature.enable(:refactor_blob_viewer)
  1. Open a file in the repository file browser

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Issue: #350455 (closed)

Edited by Jacques Erasmus

Merge request reports

Loading