Skip to content

Blob refactor: Improve blob line selection

Jacques Erasmus requested to merge improve-blob-line-selection into master

What does this MR do and why?

Slight improvement to the way we select lines in the source code by using Vue router instead of window.location for determining the hash. Also gets rid of the box-shadow when selecting a line number.

Note, changes in this MR is behind the :refactor_blob_viewer feature flag.

Screenshots or screen recordings

Screen_Recording_2022-01-19_at_14.24.06.2022-01-19_14_26_06

How to set up and validate locally

  1. Enable the Blob Viewer Refactor feature flag
Feature.enable(:refactor_blob_viewer)
  1. Open a file in the repository file browser

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jacques Erasmus

Merge request reports

Loading